[CLI] Add support for vesting contract #4786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
reviewed
Oct 5, 2022
crates/aptos/src/stake/mod.rs
Outdated
Comment on lines
25
to
27
| UnlockVestingRewards(UnlockVestingRewards), | ||
| UnlockVestedCoins(UnlockVestedCoins), | ||
| VestingDistribute(VestingDistribute), |
There was a problem hiding this comment.
These three things don't mean much to me, and as a user I wouldn't be able to tell between the three.
There was a problem hiding this comment.
Any better suggestions for naming then?
crates/aptos/src/stake/mod.rs
Outdated
Comment on lines
306
to
315
|
|
||
| #[derive(Parser)] | ||
| pub struct UnlockVestingRewards { |
There was a problem hiding this comment.
All of these commands should have a doc comment explaining what it does
crates/aptos/src/stake/mod.rs
Outdated
Comment on lines
413
to
420
| prompt_yes_with_override( | ||
| &format!( | ||
| "Unlock vested coins for vesting contract {}. Confirm?", | ||
| vesting_contract_address | ||
| ), | ||
| self.txn_options.prompt_options, | ||
| )?; |
There was a problem hiding this comment.
I might get rid of these, because it asks you again when you simulate the transaction for confirmation. But, it's fine for now
crates/aptos/src/stake/mod.rs
Outdated
Comment on lines
348
to
325
| #[derive(Parser)] | ||
| pub struct VestingDistribute { | ||
| /// Address of the vesting contract's admin. | ||
| /// | ||
| /// Defaults to the profile's address if not set. | ||
| #[clap(long, parse(try_from_str=crate::common::types::load_account_arg))] | ||
| pub admin_address: AccountAddress, | ||
|
|
||
| #[clap(flatten)] | ||
| pub(crate) txn_options: TransactionOptions, | ||
| } | ||
|
|
||
| #[async_trait] | ||
| impl CliCommand<TransactionSummary> for VestingDistribute { | ||
| fn command_name(&self) -> &'static str { | ||
| "VestingDistribute" | ||
| } |
There was a problem hiding this comment.
Let's keep all the commands as verb-item
DistributeVestingRewards
movekevin
force-pushed
the
vesting
branch
2 times, most recently
from
56b5335
to
079965b
Compare
gregnazario
approved these changes
Oct 5, 2022
bowenyang007
approved these changes
Oct 5, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is